When I installed flag_friend and went to the "View All Friends" tab I would get the following warning:

Strict warning: Declaration of flag_friend_handler_argument_numeric::query() should be compatible with that of views_handler_argument_numeric::query() in require_once() (line 8 of ~/Projects/myproject/httpdocs/profiles/myprofile/modules/contrib/flag_friend/includes/flag_friend_handler_argument_numeric.inc).

I also have stict warning showing in PHP 5.3.

I've attached a patch which fixes this issue.

Comments

Canton32’s picture

Im having the same problem. Ive looked at the patch file but seems to have some santax errors. Please exscuse this newbes ignorance if im incorrect.

You help would be greatly appreciated.

Thanks in advance

Status: Needs review » Needs work

The last submitted patch, flag_friend_strict_warning_handler_argumetn_numeric_query.patch, failed testing.

socketwench’s picture

Status: Needs work » Needs review
StatusFileSize
new541 bytes

Yeah... Really weird. It looks like a good patch. Let's try a reroll!

Status: Needs review » Needs work

The last submitted patch, 1538688.3.StrictWarningQuery.patch, failed testing.

socketwench’s picture

Version: 7.x-1.0-alpha9 » 7.x-1.x-dev

Wait, maybe Testbot doesn't like the version.

socketwench’s picture

Status: Needs work » Needs review

#3: 1538688.3.StrictWarningQuery.patch queued for re-testing.

socketwench’s picture

Status: Needs review » Reviewed & tested by the community

Bingo!

So, the lesson here is *always* select the *-dev version, never the release version!

Committed!

http://drupalcode.org/project/flag_friend.git/commit/a248bdd

socketwench’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.