chgpicture module

welcome,

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow tips for a great project page. Also create a README.txt that follows the guidelines for in-project documentation.
Also you got to remove the license file as it will be added later automatically and all code hosted on d.o is under gpl anyway.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxzeet1343136git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

Hi zeet, my manual review so far:

• Pareview issues fixed, nice
• Searched module categories for similar projects: Content Display and Theme Enhancements; I have not found another module that has the same functionality
• I have installed the module, and I see a new tab when I edit a users profile, see attachment. Am I missing something, or this is the main feature, a new tab to upload the image?
• I'm a bit confused, title and overview refers to profile picture, but the module's description refers to provides separate change password screen, see attachment.
• Please take a moment to make your project page follow tips for a great project page.
• Please take a moment to make your README.txt follow guidelines for in-project documentation.

You need to delete the master branch. See steps 6 & 7: http://drupal.org/node/1127732

Your documentation in README.txt still has a typo. Currently says:
"in seperate page at 'user/*/edit.chgpicture' page"
should say:
"in seperate page at 'user/*/edit/chgpicture' page"

Finally, I tried installing the module and it did not work. I only saw a blank config page (see attached). Vanilla D6.26 installation, tried both as admin (user 0) and regular user, with and without clean urls, using the latest version of your module from the git 6.x branch. I did not have pictures on either account prior to trying your module. Clearing caches did not help.

Please see my feedback below:

• Code looks clean, but it's a very small module (less than 120 lines of code - see: http://groups.drupal.org/node/195848).
• Module .info description could be a bit clearer as to the modules purpose.
• You need to check if Picture Support is enabled or disabled (admin/user/settings). If it's disabled then your form needs to be disabled as well. At the moment I see the tab and a 'save' button but no other functionality.
• I'm not 100% sure how having a separate tab and form is of significant advantage to the user experience, perhaps you could provide an example of usage.
• I would also agree with the previous reviewers that you need to improve the project page.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)