This issue also exists in the version of drush_make for 4.5 and would be an easy backport.

I discovered this issue when working with Vagrant; the make was working perfectly - except for libraries that came from ZIP files. Turns out unzip wasn't installed in the base box.

To replicate on Ubuntu 8.04 without unzip installed:

drush make --no-core test.make test
jquery.ui downloaded from http://jquery-ui.googlecode.com/files/jquery-ui-1.7.3.zip. [ok]
ls -la test/sites/all/libraries/jquery.ui

Result: 4.5 - empty directory
Result: 5.1 - jquery-ui-1.7.3.zip

This is tangentially related to http://drupal.org/node/1457798 - Use drush_tarball_extract() and drush filesystem commands during make. The fix I'm proposing doesn't cover that, it just throws an error if unzip fails for whatever reason.

CommentFileSizeAuthor
#1 drush_no_unzip_err-1539694.patch736 bytesfluxsauce

Comments

fluxsauce’s picture

Status: Active » Needs review
StatusFileSize
new736 bytes

This patch throws a generic UNZIP_ERROR if unzip fails for any reason.

moshe weitzman’s picture

Assigned: Unassigned » jhedstrom
Status: Needs review » Reviewed & tested by the community

Looks right to me ... There may be more instances of missing error handling we can trap similarly.

jhedstrom’s picture

Status: Reviewed & tested by the community » Fixed

This looks right to me, committed. Thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.