Closed (fixed)
Project:
OpenLayers Plus
Version:
7.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Apr 2012 at 20:07 UTC
Updated:
19 Jul 2013 at 12:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
batje commented@1 Have to currently pass on debugging that. Any takers?
@2 If you create a new issue and post a patch, we can add that.
Comment #2
chrsnlsn commentedIt's very possible that my GeoJson data format is off and that could be causing the issue, can anyone confirm that OL+ Popups isn't working with GeoJson data?
Or is there an example of well formatted GeoJson data that OpenLayers is expecting?
My latest attempt where the ToolTips function but the PopUps break looks like this.
Does that format look correct?
Points are placed correctly and tooltips work they just break when I turn on OL+ Popups.
Thanks for any help in tracking down the problem!
Comment #3
chrsnlsn commentedSolved it. Not sure where exactly the error was coming from, but now it works with both openlayers views and feeding it GeoJson directly.
Rewrote a bit of it to work with my use case where I am using OL+Tooltips Field to display an address on hover then OL+Popups to display on click so that the user can click through the multiple in this case businesses residing at that specific address. here is my code for the openlayers_plus_behavior_popup.js file in case anyone wants to take a look.
I had to add a conditional section in the openPopup function to check and see if the feature was combined using the cluster behavior or not.
Comment #4
batje commentedcan you make a patch out of this? see http://drupal.org/node/707484
Comment #5
chrsnlsn commentedAlright, first patch so a couple questions, when I cloned the module I got
git clone --branch 7.x-1.x-dev http://git.drupal.org/project/openlayers_plus.git
warning: Remote branch 7.x-1.x-dev not found in upstream origin, using HEAD instead
So I just patched against the master branch
also in the instructions it mentioned [issue-number]-[comment-number] which I guessed were the nid of this issue and the comment number of the comment I will be attaching the patch to?
Comment #6
batje commentedlooks ok.
Are you sure we should include
Not sure if everyone will have img>p>dl in their popups. (And if so, if they should be 180px)
Is there another, more generic way, to achieve what you are trying to do here?
Comment #7
chrsnlsn commentedWhoops missed that, I will roll another one and remove that.
Comment #8
davidserene commentedComment #9
Exploratus commentedI was pointed over here (https://drupal.org/node/2005996) saying this could fix clustering issues with OL popup. Nevertheless, this seems to only address the 1.x branch. Is there a patch or was this committed to the 2.x branch?