Hi,
I'm running Get Directions v7.x-2.1, and whenever I go to the /getdirections page on my Drupal 7.12 site, I see this error message at the top of the page:
Strict warning: Only variables should be passed by reference in getdirections_direction() (line 302 of /Users/rrollins/dev/workspace/www.caltech.edu/sites/all/modules/getdirections/getdirections.module).
I checked out that line, and along with a bit of googling, I figured out the problem: the render() function's $element parameter is pass-by-reference, but the drupal_get_form() function's return value can't be passed by reference. Thus, you have to store the return value of drupal_get_form() into a variable (which can be passed by reference) before passing it to render().
I've written up a patch to fix this, which is attached.
| Comment | File | Size | Author |
|---|---|---|---|
| getdirections-strict_warning_fix.patch | 708 bytes | coredumperror |
Comments
Comment #1
hutch commentedCommited fix to dev, thanks for the report.