Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Sometime in Drupal 5 or earlier, we moved the user table's access column to a separate table because it was updated every page request. In Drupal 6 and later, this only happens every 3 minutes per user, overwritable with a number of seconds in session_write_interval. I think we should not carry this hack forward to Drupal 7 since core has a different solution. It would be good to deploy this on Drupal 6, so we can verify it scales, and have one less thing changing in production on launch day.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | bzr-1540192.diff | 5.06 KB | drumm |
| #6 | drupalorg-1540192.diff | 781 bytes | drumm |
| #1 | drupal.org-56.diff | 594 bytes | drumm |
| #1 | drupal.org-61.diff | 4.74 KB | drumm |
Comments
Comment #1
drummIt appears that Drupal.org's BZR commits to revert are 56 and 61. Diffs of these are attached.
Comment #2
Gerhard Killesreiter CreditAttribution: Gerhard Killesreiter commentedIIRC Narayan has previously said that the previous advantage we've had from doing this was gone now, so it is a good idea to revert.
The patches don't seem to be complete, there is some search related stuff in there that is unrelated and it is missing the profile module which was also patched.
Comment #3
webchickWe'll also need an upgrade path to move the value of the column and then drop the table.
Comment #4
Gábor HojtsyAre we planning to do this in the pressflow based vendor branch? Localize is also merged off of that and would be happy to get rid of this customization there too :)
Comment #5
drummTag. And I'll probably end up doing this myself.
Comment #6
drummAttached are patches to remove the core hacks, and a drupalorg update to move the data. Generated by diffing against bzr+ssh://util.drupal.org/bzr/vendor/pressflow/6.x-unbranded and cherry-picking chunks with users_access.
We'll keep the table for now so we can quickly roll back without DB changes.
Gábor Hojtsy – let's do this site-by-site.
Comment #7
drummAltering the users table will lock a lot of queries, so we need a downtime. I'd like to go for Thursday May 9th 5PM PDT (0:00 UTC). Here is a draft announcement: http://drupal.org/node/1989572
Comment #8
drummNarayan had no objections, so this is being deployed in about 24 hours.
Comment #9
drummDeployed!