Comment posting pages use the default theme instead of the parent node's theme
Mapache - June 23, 2007 - 05:16
| Project: | Taxonomy Theme |
| Version: | 5.x-1.x-dev |
| Component: | Code / API |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Jump to:
Description
When posting a comment on a (non-forum-related) node that whose theme is controlled by taxonomy_theme (including following up to a comment on a node that is themed), the comment-posting page use the default site-wide theme. Expected behavior is that it should use that node's customized theme. The included patch implements this change by treating paths of the form /comment/reply/([0-9]+).* the same as paths of the form /node/([0-9]+).* , where the matched expression in both cases is the node id. It does duplicate several lines of code which could probably benefit from being refactored.
| Attachment | Size |
|---|---|
| taxonomy_theme_taxonomy.inc_.patch | 2.23 KB |
#1
Hi.
I have patched the file "taxonomy_theme_taxonomy.inc" included in "taxonomy_theme-5.x-1.1.tar.gz" with the patch file "taxonomy_theme_taxonomy.inc_.patch", doing (I am using Debian GNU/Linux):
> patch taxonomy_theme_taxonomy.inc taxonomy_theme_taxonomy.inc_.patch
patching file taxonomy_theme_taxonomy.inc
>
And... everything is working fine now! The comment-posting page use the correct theme now. I think that the patch file is OK. Why not is it included to the next release?
Alert! If you try to do the same but using file in "taxonomy_theme-5.x-1.x-dev.tar.gz" to be patched, the patch process goes on, but the resulting file doesn't work fine.
Thanks, Mapache.