convert user deletions to deletion API [#154033]

Comment	File	Size	Author
#6	dapi_user_1.patch	9.23 KB	hunmonk
#5	dapi_user_0.patch	9.31 KB	hunmonk
#4	dapi_user.patch	9.29 KB	hunmonk
#1	user_deletions_0.patch	9.29 KB	hunmonk
	user_deletions.patch	10.83 KB	hunmonk

Comment #1

hunmonk commented 23 June 2007 at 06:51

Status	File	Size
new	user_deletions_0.patch	9.29 KB

dww pointed out that we can handle update queries just like deletion queries, instead of passing them to a post-deletion callback. this version is much cleaner...

Log in or register to post comments

Comment #2

dww

we/he/they

commented 23 June 2007 at 07:28

After that initial correction, this mostly looks great. I haven't tested it yet, so I can't RTBC.

My only minor gripe is really a gripe w/ DAPI itself (and I'm surprised this got past Steven in the first place) -- I find the 'path' and 'destination' keys for the array you pass to hook_delete_confirm() too ambiguous to know what to do as a developer. I suspect a lot of people will waste a lot of time looking up docs to figure out what's what. 'path' should be renamed 'cancel', or something. :( But, that really isn't a reason to hold up this patch. I just wonder if we could do something about this before a) the code freeze and b) too many more DAPI conversions are done. Food for thought.

Otherwise, I tried *really* hard to find something wrong with this patch, but couldn't. ;)

Log in or register to post comments

Comment #3

dww

we/he/they

commented 23 June 2007 at 07:57

Status:

Needs review

» Postponed

Ok, I submitted http://drupal.org/node/154046 at the request of UnConeD and hunmonk about fixing 'path' vs. 'destination'. I think this patch should be on hold pending the outcome of that other effort.

Log in or register to post comments

Comment #4

hunmonk commented 23 June 2007 at 18:47

Status	File	Size
new	dapi_user.patch	9.29 KB

...and here's an updated patch that will work after http://drupal.org/node/154046 gets in...

Log in or register to post comments

Comment #5

hunmonk commented 24 June 2007 at 15:31

Status:

Postponed

» Reviewed & tested by the community

Status	File	Size
new	dapi_user_0.patch	9.31 KB

final patch based upon the committed confirm form changes. all code is the same except for those tweaks. patch is tested as working.

Log in or register to post comments

Comment #6

hunmonk commented 24 June 2007 at 19:25

Status	File	Size
new	dapi_user_1.patch	9.23 KB

one more tiny fix -- we want the user post deletion callback to be part of user_delete(), so the user info is always handled correctly when user_delete() is used by any other modules.

re-tested, and still working perfectly.