Closed (fixed)
Project:
CRM Core
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
20 Apr 2012 at 10:19 UTC
Updated:
30 May 2014 at 18:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dpovshed commentedLet me handle these topics, should be related to http://drupal.org/node/1534858
Comment #2
dpovshed commentedPlease test/review attached patch.
What is done and included in this patch:
- on contact type deletion existing contacts of that type are deleted automatically
(all attached activity will reflects the deletion of contacts in cascade way);
- deletion callback function name now have the same suffix for Activity and Contact (*_delete_callback);
- link to CRM contact type added to admin/structure/crm/ menu
- minor fixes of unused variables/incorrect formatting;
What is NOT done:
- 'Delete' button not added to contact deletion form. The reason is that currently three management tabs have a different design:
admin/structure/crm/relationship-types
admin/structure/crm/contact-types
admin/structure/crm/activity-types
I believe making them to have same look is a topic for a new separate ticket for a person with love to UI stuff.
Comment #3
dpovshed commentedRework of previous patch according to code review.
in addition to patch in #2 the following was done:
- functional moved from "deletion callback" function type controllers;
- signature of crm_core_contact_type_delete() function standartized;
- minor controller syntax fixes
Comment #4
dpovshed commentedAdopting previous patch to current dev version
Comment #5
ygerasimov commentedCommitted! Thanks God for the codesprint! http://drupalcodesprint.com/
Comment #6
ygerasimov commented