Hello guys,

Are there any plans (or maybe even a sandbox) to get Commerce Feeds working with Feeds 7.x-2.

( This Feeds issue http://drupal.org/node/1428272, for which a patch for 7.x-2 has been provided, addresses a problem of importing from non-UTF8 encoded CSVs, and it's quite an issue when using Drupal Commerce in, say, ex-Soviet Union countries where accountancy software often spits out exports in Cyrillic with Microsoft-specific encodings)

Comments

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Not sure of what you mean.

Are there any plans (or maybe even a sandbox) to get Commerce Feeds working with Feeds 7.x-2.

There's no release for Feeds 1.x in Drupal 7, this module is already for Feeds 2.x.

stan turyn’s picture

stan turyn commented

My apologies, pcambra, I wasn't paying attention, just went by this quote "Since commerce_feeds dev branch haven't been updated to accomodate severe changes in the feeds 2.x git branch yet (getting error message: Class FeedsCommerceProductProcessor contains 2 abstract methods .... ), I had no chance to test the patch.", not noticing the git branch mention. My bad.

Anyway, it's probably better to close this issue. Commerce Feeds does not work with Feed-7x.2-dev with that patch applied (the prices do not get imported with the exception of the very first entry in CSV, with all the rest having zero as their price) but I cannot open an issue for that as it would be silly to ask you to look into dev version of Feeds with a not-yet-accepted patch.

Once again, apologies.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

I just updated feeds to the latest -dev of the 2.x branch and commerce feeds is working as expected. Prices are ok and no error so it may be the issue.

I've set to Follow the issue on Feeds that you're referencing because we may need to implement some methods on the product class.

Are you using php 5.4 by any chance?
https://bugs.php.net/bug.php?id=61398
https://bugs.php.net/bug.php?id=61219

Not changing the category because there's no "Future bug report" category ;)