css not working

stBorchert - June 23, 2007 - 18:20
Project:Todolist
Version:5.x-1.x-dev
Component:User interface
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

I've tested the module and none of your css-rules is working (and the images aren't shown either).
Why do you build the css file into a php file and do a BOOTSTRAP_FULL? A simple css is working fine (see attached patch). No need to write the complete path to the images :-)

hth,

Stefan

PS: I've replaced todolist.css.php with todolist.css

AttachmentSize
todolist_css.patch2.58 KB

#1

mikesmullin - June 23, 2007 - 22:52
Status:needs review» fixed

Excellent observation, Stefan! Patch applied to HEAD.

Thanks for your contribution. :)

#2

Christefano - June 24, 2007 - 00:40
Status:fixed» active

Todolist looks great and works well in Garland, but its CSS completely destroys some third-party themes like amadou.

AttachmentSize
todolist_css_amadou.png 44.69 KB

#3

stBorchert - June 25, 2007 - 07:52

Are you sure its because of todolist.css?
The stylesheet is only loaded and used if you visit a "todolist" node (look at the source of admin/build/themes: it's not there).
I've tested amadou and it looks fine. But todolist isn't displayed correct (remove, edit, move are not shown).

#4

Christefano - June 25, 2007 - 08:37

Yes, the CSS gets seriously borked when Todolist is enabled (I had CSS aggregation turned off). Disabling Todolist restored the navigation block, etc. in amadou. I was wondering if I was using a modified version of amadou, so I downloaded a fresh copy and it was still malfunctioning when Todolist is enabled.

#5

stBorchert - June 25, 2007 - 11:38

Hm, that's really weird.
Could you please check the html source of a page that is broken. "todolist.css" shouldn't be included (if it is, there's an error in the module I didn't see, yet).

AttachmentSize
todolist.png 34.65 KB

#6

mikesmullin - October 28, 2007 - 23:56

@christefano: can you confirm this is still an issue?

#7

marvil07 - October 8, 2009 - 20:13
Status:active» fixed

I think this was solved a long time ago, but reopen it if it's needed

#8

System Message - October 22, 2009 - 20:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.