The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.This has been bothering me in 7 for a little bit now. In 8 we no longer need the embed prefix we put in inline css/js.
Just to make it clear I'm talking about this:
<!--//--><![CDATA[//><!--
//--><!]]>
Anyways here's a 1st attempt at it.
I'm pretty sure this will failed some test.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | drupal-1541438-13.patch | 5.04 KB | ericduran |
| #10 | 1541438-10.patch | 2.66 KB | ericduran |
| #6 | 1541438-cdata-6.patch | 8.28 KB | Niklas Fiekas |
| #6 | 1541438-cdata-6-interdiff.txt | 5.23 KB | Niklas Fiekas |
| #3 | 1541438-remove-cdata-3.patch | 4.75 KB | ericduran |
Comments
Comment #1
ericduran commentedfor the testbot
Comment #3
ericduran commentedComment #5
ericduran commentedTagging so I can get so help on moving this forward since I forgot about it.
Technically since we're using the html5 doctype cdata tags are no longer needed, lets remove them.
Comment #6
Niklas Fiekas commentedThis patch fixes the failing tests but also touches the filter module. Let's see what new problems that would introduce.
Comment #8
ericduran commentedPersonally I think we should also remove filter_dom_serialize_escape_cdata_element, all cdata is pretty much useless unless you're trying to validate against xhtml.
Comment #9
ericduran commentedTagging and bumping for myself :)
I want to make sure we get this in before Dec :)
Comment #10
ericduran commentedOk Lets give this another try.
Comment #11
ericduran commentedLatest patch tries to avoid the filter module for now. I really only care about the script tags.
We can come back to the other stuff later.
Comment #13
ericduran commentedOk this should fix this once and for all.
Comment #15
geek-merlinFixed in #1021622: Improper escaping of CDATA for inline css for css. Please reopen if this is an issue for js still.
Comment #16
quietone commentedtag cleanup