Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Now when D6 supports translations of nodes, search module should be updated to index words according to languages and let user limit searching to particular languages.
Comment | File | Size | Author |
---|---|---|---|
#13 | search-languages.patch | 2.37 KB | robertDouglass |
#10 | search-languages.patch | 2.19 KB | robertDouglass |
#3 | search-languages.patch | 2.26 KB | robertDouglass |
Comments
Comment #1
Gábor HojtsyModified title.
Comment #2
meba CreditAttribution: meba commentedBumping to 7.x
Comment #3
robertDouglass CreditAttribution: robertDouglass commentedVery straightforward. Note that this doesn't provide and method for setting search preferences, you have to set the language every search. This is consistent with the other advanced search features.
Comment #4
Damien Tournoud CreditAttribution: Damien Tournoud commentedIt does not make much sense to use checkboxes for the language selection. I would rather see a select box here (a search term is rarely the same across different languages). Otherwise, the patch looks good.
Comment #5
Damien Tournoud CreditAttribution: Damien Tournoud commentedOh, and as a next step, we will also need a language-specific steemer and user-language aware search (but that's for another feature request).
Comment #6
robertDouglass CreditAttribution: robertDouglass commentedselect or radios? Which do people think are better?
Comment #7
meba CreditAttribution: meba commentedCheckboxes are respecting usability a little bit more because they present the choices directly to the user. But I am afraid we need to be consistent with the fact, that thay may be too many languages enabled so I vote for the select box too.
Comment #8
robertDouglass CreditAttribution: robertDouglass commentedActually, I disagree. If Drupal.org were a mishmash of languages, I'd still search for Drupal in de and en.
Comment #9
Damien Tournoud CreditAttribution: Damien Tournoud commentedWould you really search the *same exact word* in both English and German? Even if it could, as a corner case, make sense (for instance for family names or names of organizations), I'm not sure it would be really useful.
Comment #10
robertDouglass CreditAttribution: robertDouglass commentedThis one makes it a select. The side effect is that you can only search for one language, even if you use a syntax like language:en,ar,de, it won't work. The select now contains an option "All" which is the default.
Comment #11
Gábor HojtsyWell, especially with German, there are lots of words which that language share with English, at least in the tech world I know. I'd support selecting multiple languages. Why make it impossible?
Comment #12
robertDouglass CreditAttribution: robertDouglass commentedI should be able to work it out so that we have a select widget, but the extraction supports multiple values (so a url with language:en,de,ar would work). That way someone could come along and form_alter the widget if they need. Will do this tomorrow unless someone else takes a stab.
Comment #13
robertDouglass CreditAttribution: robertDouglass commentedThis one leaves the select widget but allows for language:en,de,jp,ar syntax.
Comment #14
Dries CreditAttribution: Dries commentedI might want to search for the word 'Drupal' in English, Dutch and French, but not in Chinese or Japanese. A lot of words, and names in particular, are language independent. I think this is a nice little improvement. (Would even be better if it came with a simpletest.)
Comment #15
Dries CreditAttribution: Dries commentedI've tested this some more and committed it to CVS HEAD. Thanks.
Comment #16
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.