Using twitter_bootstrap all forms don't work at all in Internetexplorer 6 and Internetexplorer 7.

After some debugging I noticed that this browsers need type = "submit" in the button element.
See http://www.thefutureoftheweb.com/blog/button-wont-submit-in-ie.

CommentFileSizeAuthor
#4 twitter_bootstrap_form_submit_not_working_ie7-1541630-4.patch641 bytesqueenvictoria
#1 twitter_bootstrap_form_submit_not_working_ie7-1541630.patch742 bytescriz

Comments

criz’s picture

criz
he/him
Location Vienna/Austria
commented
Status: Active » Needs review
StatusFileSize
new twitter_bootstrap_form_submit_not_working_ie7-1541630.patch742 bytes

here is the patch.

tmsimont’s picture

tmsimont commented

Might I ask -- why use the button tag? Drupal uses inputs over buttons, and AFAIK the button tag is not reliable in IE6-7 for multiple-submit-button forms... Wouldn't it be better to just use Drupal standard and go with input?

sariel’s picture

sariel commented

Not to sound mean, but IE6 has zero support and IE7 is soon to follow. Why develop for a browser that's 6 years old and can't even use most the styling techniques commonly used today?

queenvictoria’s picture

queenvictoria commented
StatusFileSize
new twitter_bootstrap_form_submit_not_working_ie7-1541630-4.patch641 bytes

My fix is to add type to the elements list. 

//  element_set_attributes($element, array('id', 'name', 'value'));
  element_set_attributes($element, array('id', 'name', 'value', 'type'));

@sariel -- it's an easy fix. Some orgs can't upgrade their old pc's / windows due to cost. It's a one line fix--why not fix it?

frankbaele’s picture

frankbaele commented

thx for the fix will be added to the theme

frankbaele’s picture

frankbaele commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

andregriffin’s picture

andregriffin commented
Project: Twitter's Bootstrap » Bootstrap