When creating or editing path redirects with Redirect module, one must enter a path and hence suffers from the same difficulties as when creating menus or shortcuts.

Proposed solution: add autocomplete provided by this module to add/edit redirect form. As redirects are usually created to publicly available pages, I suggest using the autocomplete path as for menus.

Patch (on top of #1541678: Windows line endings in mpac.module) attached.

Comments

stborchert’s picture

Status: Needs review » Needs work

I suggest creating a patch for redirect to change the autocomplete path if mpac is installed.
mpac provides the methods and alters core menu fields. Im my opinion contrib modules using such fields may (or may not) integrate mpac. Not the other way round.

Example: Token (for D6). Guess, each module using tokens would force token to create a module-specific form_alter (or something similar) because it would like to use or provide tokens ... not a good idea ;)

Thoughts?

Drave Robber’s picture

Makes sense. (Although the Token example probably doesn't compare in scale - tokens are used in way more places than there are forms requiring one to enter a path - in principle it's the same.)

On the other hand, then it would also be more convenient if MPAC had its methods named in a more descriptive manner - now they're named by purpose (e.g. 'menu', 'shortcut'), but developers of other modules would rather look for 'public', 'admin' or 'all'. Just a thought. :)

klonos’s picture

Hey Drave! Did you file an issue for this over at Redirect module's issue queue? If so, care to link to that issue? Thanx in advance.

Drave Robber’s picture

No, I didn't, thank you for reminding. :)

It seems I even rolled a patch, and then something/somebody distracted me. I'll re-roll it against the latest Redirect, file it and let you know.

Drave Robber’s picture

Status: Needs work » Closed (won't fix)