In promotion_form_submit(), drupal_goto() is used to redirect after the form has been submitted. However, it is better to return the path and let the Forms API do the redirect. This will allow other modules to use #submit when altering promotion_form and be called on submission.

CommentFileSizeAuthor
promotion-submit.patch543 bytesdecafdennis

Comments

zostay’s picture

zostay commented

Thanks!

I'll try it out and look into applying it for the next release.

zostay’s picture

zostay commented
Status: Needs review » Reviewed & tested by the community

Patch works as advertised. I will apply it shortly.

zostay’s picture

zostay commented
Status: Reviewed & tested by the community » Fixed

Applied to HEAD and will be part of the 1.8 release.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)