Using 7.x-1.x (as of 04/22/12) causes overlays to hang when underlying page and the overlay are mixed http / https.
securepages_goto() (in module securepages.module) is suppose to detect the render overlay, but does not.
It currently checks if $_GET['render'] exists and matches 'overlay'. While on entry to drupal, $_GET does have this set, by the time this function has been driven, $_GET no longer contains the render element. It instead has the 'q' element with the target page for the overlay. As a result, the overlay is not detected and does not get unset.
$url, after parsing, does have the ['query']['render'] value set to overlay.
I am using drupal 7.12
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1542618_securepages-overlay_1.patch | 678 bytes | David4514 |
Comments
Comment #1
David4514 commentedI've attached a patch where I have included a test for $url['query']['render'] == 'overlay'. What I do not know is whether or not the test for $_GET['render'] may still be required in other circumstances.
At least on my website, this seems to be working.
Comment #1.0
David4514 commentedspelling error
Comment #2
hanoiiThis is very old and the patch doesn't work for latest version.
My approach to sort this, if you really don't want to disable overlay altogether, which I recommend, is to have admin roles always under SSL, thus preventing any real issue with mixed sessions.
Comment #3
hanoiiThe issue itself, although it seems a fix in latest dev attempted to fix it, is still there, at least on some pages.
On my case I am using ubercart, and if I go from /cart to any admin pages it just doesn't work.
Comment #4
astonvictor commentedI'm closing it because the issue was created a long time ago without any further steps.
if you still need it then raise a new one.
thanks