attached patch converts role deletions to the deletion API. previously, role deletions happened without a confirmation screen, which i thought was kind of dangerous -- so they've been converted to use a confirm screen in this patch.

tested as working.

CommentFileSizeAuthor
#1 dapi_roles_154266.patch3.3 KBdrewish
dapi_roles.patch3.22 KBhunmonk

Comments

drewish’s picture

StatusFileSize
new3.3 KB

i was getting an undefined index warning for the rid in user_admin_role_submit() when adding a new role. i reverted back to using $form_state['values']['name'] and $form_state['values']['rid']. otherwise it works great.

hunmonk’s picture

Status: Needs review » Reviewed & tested by the community

code style is good. tested the patch, and it works perfectly.

note that you need to make sure that your menu cache has been cleared in order to test this patch, as it adds a new menu item...

jvandyk’s picture

Confirmed that the patch works as described.

hunmonk’s picture

Assigned: hunmonk » Unassigned
webchick’s picture

Status: Reviewed & tested by the community » Closed (won't fix)

Deletion API was rolled back.