attached patch converts block deletions to the deletion API. also fixed up a $form_state problem with block deletions, so the patch can be properly tested.

CommentFileSizeAuthor
#4 dapi_block_1.patch1.91 KBhunmonk
#3 dapi_block_0.patch2.01 KBhunmonk
dapi_block.patch1.91 KBhunmonk

Comments

drewish’s picture

drewish commented

i couldn't test this completely because there's a bug that prevents a blocks roles from being saved but it would seem to me that we should be deleting records from {block_roles} as well...

drewish’s picture

drewish commented

http://drupal.org/node/152585 fixes the saving problem...

hunmonk’s picture

hunmonk commented
StatusFileSize
new dapi_block_0.patch2.01 KB

re-rolled to include removing data from {blocks_roles}. looking at the code in HEAD, it seems that we've never deleted from {blocks_roles} when a block is deleted! perhaps we should work up a db upgrade for that. out of scope for this patch, of course...

hunmonk’s picture

hunmonk commented
StatusFileSize
new dapi_block_1.patch1.91 KB

re-rolled again to stay current w/ HEAD.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Tested and works! RTBC.

hunmonk’s picture

hunmonk commented
Assigned: hunmonk » Unassigned
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Closed (won't fix)

Deletion API was rolled back.