Internal server error when using rules [#1543424]

I was trying to fix this issue #1541800: History doesn't get updated after comment has been saved by using a rule on "comment save"

if ([current-user:uid]) {
   db_merge('history')
     ->key(array(
       'uid' => [current-user:uid],
       'nid' => [comment:node:nid],
     ))
     ->fields(array('timestamp' => [site:current-date]))
     ->execute();
  }

This rule executes fine when I have the ajax comments module turned off.
When I turn it off I this error in a popup when I try to submit a comment:

An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /mt/system/ajax
StatusText: Internal Server Error
ResponseText: [{"command":"settings","settings":{"basePath":"\/mt\/","pathPrefix":"","ajaxPageState":{"theme":"bartik","theme_token":"J_NTC7ULEM ....

The comment does get saved. Any idea how to fix that?

Comments

Comment #1

Berdir

German

Switzerland

CreditAttribution: Berdir commented 23 April 2012 at 18:29

Internal Server error is usually a PHP Fatal Error.

Try to turn on error logging in PHP if it isn't already and then check your server error logs for the actual error.

Comment #2

mototribe CreditAttribution: mototribe commented 24 April 2012 at 03:52

Thanks Berdir, great idea!

I'm getting:

PHP Parse error: syntax error, unexpected '[' in /Users/uwe999/Sites/mt/sites/all/modules/rules/modules/php.eval.inc(125) : eval()'d code on line 3

When I replace the tokens with dummy values it works fine.
Maybe I'm better off using a hook_comment_insert?

cheers
UWE

Comment #3

mototribe CreditAttribution: mototribe commented 24 April 2012 at 17:36

This hook seems to work fine for me now:

function hook_comment_insert($comment) {
  //dpm($comment);
  
  if ($comment->uid) {
   db_merge('history')
     ->key(array(
       'uid' => $comment->uid,
       'nid' => $comment->nid,
     ))
     ->fields(array('timestamp' => REQUEST_TIME))
     ->execute();
  }
}