Enable module > create toplevel filedepotfolder > add a couple of pdf files > save - error message

Filedepot Folder MailFiles has been created.
moving file to: private://filedepot/1/2011 Newmarket Leisure Centre Paralympic Sports Day time table.pdf - private://filedepot/1/2011 Newmarket Leisure Centre Paralympic Sports Day time table.pdf
moving file to: private://filedepot/1/Certificate of Insurance Calkin .pdf - private://filedepot/1/Certificate of Insurance Calkin .pdf
Error message
Strict warning: Only variables should be passed by reference in filedepot_native_submit() (line 745 of D:\xampp\htdocs\aatmp\sites\all\modules\filedepot\filedepot.module).
Strict warning: Only variables should be passed by reference in filedepot_native_submit() (line 745 of D:\xampp\htdocs\aatmp\sites\all\modules\filedepot\filedepot.module).

Comments

_timpatrick’s picture

_timpatrick commented
Assigned: Unassigned » _timpatrick

I tried to recreate the issue but couldn't get it to give me an error / warning - would you be able to retry with the latest dev version and see if it is still an issue?

Thanks

_timpatrick’s picture

_timpatrick commented
Status: Active » Postponed (maintainer needs more info)
_timpatrick’s picture

_timpatrick commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
dalberts69’s picture

dalberts69 commented

Same issue here, even with dev:

Strict warning: Only variables should be passed by reference in filedepot_native_submit() (line 754 of /sites/all/modules/filedepot/filedepot.module).
Strict warning: Only variables should be passed by reference in filedepot_newfile_submit() (line 1987 of /sites/all/modules/filedepot/filedepot.module).
Strict warning: Only variables should be passed by reference in filedepot_newfile_submit() (line 2061 of /sites/all/modules/filedepot/filedepot.module).

Also:

Strict warning: Only variables should be passed by reference in include() (line 315 of /sites/all/modules/filedepot/theme/filedepot-mainpage.tpl.php).

When viewing the filedepot front end page.

Centos 6.2
nginx
php 5.4
Drupal 7.14
filedepot 7.x-1.x-dev

Fixed these by pulling the nested functions out:

Line 754, 1328, 1987, 2061 of filedepot/filedepot.module
$filename = explode(".", $file->filename); $ext = end($filename);

Line 315 of filedepot/theme/filedepot-mainpage.tpl.php:
$form = drupal_get_form('filedepot_newversion_form'); print drupal_render($form);

blainelang’s picture

blainelang commented
Status: Closed (cannot reproduce) » Fixed

I was not seeing the errors reported for the lines you reported in #4 but I've made the changes and committed them.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.