drupalLogout() should only do one request, not two

Excellent findings + patch!

+++ b/core/modules/simpletest/drupal_web_test_case.php
@@ -1265,8 +1265,8 @@ class DrupalWebTestCase extends DrupalTestCase {
+    $this->assertResponse(200, t('User was logged in.'));

s/in/out/

Awesome patch. Thanks a lot, @c960657!

Looks good. Committed to 8.x. Thanks.

This can actually be backported. It's a (very) small, but still, a test performance improvement.

This did not get pushed yet, setting back.

http://drupalcode.org/project/drupal.git/commit/9dd0e7b

Not sure if I'm misunderstanding this, because I don't know how this test is passing.

The code in this patch directly follows this hunk:

+++ b/core/modules/system/tests/menu.testundefined
@@ -257,8 +256,8 @@ class MenuRouterTestCase extends DrupalWebTestCase {
   function testAuthUserUserLogin() {
-    $this->loggedInUser = $this->drupalCreateUser(array());
-    $this->drupalLogin($this->loggedInUser);
+    $web_user = $this->drupalCreateUser(array());
+    $this->drupalLogin($web_user);
 
     $this->drupalGet('user/login');

Duh. I clearly did not read how drupalLogin worked. Reroll for D7.

There were some oddities in AccessDeniedTestCase that were cleaned up in #1373142: Use the Testing profile. Speed up testbot by 50%.

A chunk of the same code, including drupalLogout(), was called twice in a row.

It seems that testUserActionAssignmentExecution is logging in as a user, blocking the user it's logged in as, unblocking it while still theoretically logged in as the blocked user, creating a new user with the same variable name as the newly unblocked user, and trying to log in as that new user.

So I'm a little unsure how to resolve that.

Well this feels like cheating, but okay.

Works for me. Trigger is a dead end either way. ;)

If this change broke several core tests, then how is it safe for D7 backport? Won't it break contrib tests too?

+++ b/modules/simpletest/drupal_web_test_case.php
@@ -1240,8 +1240,8 @@ class DrupalWebTestCase extends DrupalTestCase {
-    $this->drupalGet('user/logout');
-    $this->drupalGet('user');
+    $this->drupalGet('user/logout', array('query' => array('destination' => 'user')));
+    $this->assertResponse(200, t('User was logged out.'));

You're right. The assertResponse() cannot be backported, only the combination into a single drupalGet() can.

Let's make sure to have a patch that only contains that change, so we can see whether anything breaks with that only.

Fair point.

This needs to pass or this cannot be backported.

Alrighty.

how to test user logout?
I am using following code to test the logout function.
how to get $this value or user value.
$this->drupalGet('user/logout', array('query' => array('destination' => 'user')));
$this->assertResponse(200, t('User was logged out.'));
I am new for testing.I don't how to test in drupal.

This issue is closed for a long time already, and is not a support ticket. See http://drupal.org/simpletest for the testing handbook.

Restoring issue title.