When in a node that is present in a group, the contextual search allows to search on nodes of the same type present in the same group. However the group name is not truncated properly which introduces a problem in the layout of some themes.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1546746-commons-og-search-filter-7.patch | 2.22 KB | ezra-g |
| #6 | Scisco Oppeto Veniam Saepius Accumsan | a.jpg | 75.93 KB | ezra-g |
| #5 | 1546746_search_box_theme_shorten.patch | 1.8 KB | greggles |
| #1 | commons_core.contextual_search_limit.patch | 1.88 KB | hernani |
Comments
Comment #1
hernani commentedThe following patch makes the group name truncating consistent:
Comment #2
ezra-g commentedMarking as "needs review" and tagging for review for the 2.7 release.
Comment #3
ezra-g commentedAdding a descriptive issue title.
Comment #4
gregglesShouldn't this be truncate_utf8 or at least drupal_substr instead of substr?
Comment #5
gregglesHow about this? It also gets drupal_strlen instead of strlen.
Comment #6
ezra-g commentedThe string handling looks good but unfortunately this uncovers a bug in og_features that causes the breadcrumb to not match the search filter when a node is in multiple groups. Not sure why we have og_features_get_group_context() but that's returning different context than og_get_group_context(), which it appears to duplicate.
Comment #7
ezra-g commentedThis patch simply uses og_get_group_context() to set the group filter and resolves the problem in #6.
Comment #8
ezra-g commentedThis is committed. Thanks!
http://drupalcode.org/project/commons.git/commitdiff/18885b5?hp=5038a5e5...