Move negotiation tests to language module

In fact locale_test.module is no more after the patch, so it would not make sense to reference it anymore or try to look up its directory. We have loaded it for tests where I don't see why it would have been needed (I think that is only copy-paste cruft there) and referenced the JS and translation dir explicitly.

Rename related testcases in preparation for language module move. Depend them on language module vs. locale module. The affected testcases are intermixed with other testcases working with content, users, paths, UI translation in locale.module. The content, user, path, etc. tests should be moved to the respective modules in other issues.

It is not really surprising a 0 byte patch would pass :D Here is it again with a little bit more change in path tests which also has one piece that should be with language module instead.

Unfortunately one of the negotiation tests also marginally use localization to test that the right language was used. I think it can still go to language module tests, since we categorize tests by their main functionality. Ie. locale tests use path module and sometimes vice versa; it is the main focus of the test that makes it put where it is. (Still not actually moving the tests, so all changes are directly visible that are required to be moved).

Meh. Empty patch again. (Note to self: train eye to look at file size :).

Would also need a reroll likely now that #1539072: Support for disabled languages broken, drop it landed.

Moving back to needs review for testbot.

Why is this line in the patch, if there are no changes?

-    $admin_user = $this->drupalCreateUser(array('administer languages', 'translate interface', 'access administration pages', 'administer blocks'));
+    $admin_user = $this->drupalCreateUser(array('administer languages', 'translate interface', 'access administration pages', 'administer blocks'));

The filename does not matter as long as its .patch. I guess you might have edited the file directly instead of rolling it with git?

So as said above LanguageNegotiationTestCase (formerly LocaleUILanguageNegotiationTest) needs the 'translate interface' permission. I fixed the locale dependency of that partially in #6 but did not add this permission back. Rerolled from #6 because interim patches were in wrong format.

Same thing but now actually moving the tests too. If #17 looks fine, this should be committable :) Please review! This is a very simple thing, should not take much time, right? :)

#17 is almost what you are asking for and was purposefully limited to just that diff :) It does include a move of locale_test module to language_test, and its just replacing 'locale_test' with 'language_test' in function prefixes and tiny changes in the description in the info file. No code change to the test module *at all*.

Set renamed = copies in my git setup as per http://drupal.org/node/1542048 on suggestion from @xjm to make it easier to review the .module file changes (which as said are only as required). It did not recognize the .info file as renamed I guess due to the relatively high amount of change (locale => language) in the file. So rerolled #17 with that.

Any comments on the changes so we can roll a patch which really moves stuff? :) (renames = copies would not help with moving the tests themselves, since they are not files).

Thanks! Fixed #1 and #2. Added this comment for #3:

    // We also use language_test module here to be able to turn on content
    // language negotiation. Drupal core does not provide a way in itself
    // to do that.
    parent::setUp('locale', 'language_test');

The language negotiation functionality is in language module (and is tested more directly in LanguageNegotiationInfoTestCase which also turns on content language negotiation via language_test.module. Locale module depends on language module, so I think as long as a test relies on locale module to do things, it could just as well rely on language module provided stuff too (such as its test utilities).

(The patch did not include the test moves, I'll create a patch with that once this looks good :).

Ok, same patch now with actually moving the tests too. Given the actual test changes were reviewed, should be good I hope :)

Meh, right, language.test was not even included with the patch :/ This one has it. Sorry.

Patch did not apply due to #1497230: Use Dependency Injection to handle object definitions committed about 90 min ago :)

This did not apply due to #1183208: Remove variable_get('clean_url') and switch to index.php/path pattern for dirty URL support. Rerolled. Should hopefully get in before it conflicts again :/

#37: move-negotiation-tests-37.patch queued for re-testing.

Reroll since this did not apply anymore due to #1552236: Move user language tests to user module being committed. Should be good, no?

#40: move-negotiation-tests-40.patch queued for re-testing.

Rerolled. Please, pretty please I beg you commit this before applying all kind of other fun patches that necessitates painful rerolls. I'm tired of this.

All right, unittestbase not needed in locale.test anymore, needed in language.test now though.

The path test that was moved did not get its base class updated.

Please commit.

Yay, finally, thanks.