1. Name:
    Disapprove Comment Link
  2. Description:
    This small module provides a possibility to disapprove comment by adding a "disapprove" link (same as "approve" link, but oposite). Views integration is also provided.
  3. Link to a sandbox project:
    http://drupal.org/sandbox/barbun/1545350
  4. Git repository link: 
    git clone --branch 7.x-1.x http://git.drupal.org/sandbox/barbun/1545350.git disapprove_comment_link
cd disapprove_comment_link
  5. For Drupal 7 use.

    6. There's also my issue + patch for Drupal 7 core and Views, but since it's not committed to
    the HEAD and not released yet, I thought that it would be cool to provide this solution in a way of module.

    Issue : http://drupal.org/node/1545220

    There's also an issue for Drupal 8 (+patch): http://drupal.org/node/1266306

    Thank you!
    My best,
    ROMAN

CommentFileSizeAuthor
disapprove_comment_link_2.jpg87.76 KBbarbun
disapprove_comment_link_1.jpg47.08 KBbarbun

Comments

barbun’s picture

barbun commented

I've run it through Code Sniffer, and still there are few notices. But, i cannot change them due to the way Views contrib module was written (class methods names etc.).

FILE: ...te/includes/disapprove_comment_link_handler_comment_link_disapprove.inc
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
10 | ERROR | Class name must begin with a capital letter
10 | ERROR | Class name must use UpperCamel naming without underscores
25 | ERROR | You must use "/**" style comments for a function comment
25 | ERROR | Method name
| | "disapprove_comment_link_handler_comment_link_disapprove::render_link"
| | is not in lowerCamel format, it must not contain underscores
barbun’s picture

barbun commented
Status: Active » Needs review
luxpaparazzi’s picture

luxpaparazzi commented
Status: Needs review » Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
The following git branches do not match the release branch pattern, you should remove/rename them. See http://drupal.org/node/1015226

  remotes/origin/7.x-1.0

Review of the master branch:
ls: impossible d'accéder à *.info: Aucun fichier ou dossier de ce type

  • README.txt is missing, see the guidelines for in-project documentation.

    • grep: .info: Aucun fichier ou dossier de ce type
    grep: .info: Aucun fichier ou dossier de ce type
    grep: .info: Aucun fichier ou dossier de ce type
    Usage: file [-bchikLNnprsvz0] [--apple] [--mime-encoding] [--mime-type]
    [-e testname] [-F separator] [-f namefile] [-m magicfiles] file ...
    file -C [-m magicfiles]
    file [--help]
    grep: *: Aucun fichier ou dossier de ce type
    grep: *: Aucun fichier ou dossier de ce type

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

luxpaparazzi’s picture

luxpaparazzi commented

the GIT repro seems to be empty!

barbun’s picture

barbun commented
Status: Needs work » Needs review

Thanks, I gave the wrong git clone link, so that's why problems appeared. My bad.
P.S.: No, i wasn't working in a master branch, this lesson already learned:)

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Needs work

Hello!

Code is looking good to me, and the automated reviews give no warnings (except the ones you are mentioning).

I do however have a couple of minor issues:
- Why is the module dependant on views? Only a part of the functionality is dependent on that, but it is not required for the basic functionality. Could you either do it as 2 modules, or just wrap stuff in a module_exists call to avoid this?
- The "disapprove" link shows up on comments that are not approved. You should probably do a check on this.

Minor issues, but should be easy to fix, so marking as needs work (as there are not much work needed :)) Will come back when you have fixed this, and mark as RTBC.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Fixed clone link