I was fairly confused about the column named "Moderate" in admin/workbench/drafts and admin/workbench/needs-review.

It shows "Draft" and "Published" as links, but what really does is "Change state to Draft" and "Change state to Published". The "Moderate" column should also be renamed to "Moderate operations" or "Change moderation states".

The missing confirmation behind the links actions may not that large problem, but the wrong link text is really a heavy usability problem and caused us ~20 publish actions when this was for sure not planed to get published.

Can we change the text of the links and the column, please?

CommentFileSizeAuthor
#21 workbench_moderation_1548050+Change+Moderate+to+Set+moderation+state2.patch4.46 KBhass
#20 workbench_moderation_1548050+Change+Moderate+to+Set+moderation+state2.patch4.46 KBhass
#19 workbench_moderation_1548050+Change+Moderate+to+Set+moderation+state.patch3.12 KBhass
#14 1548050-14.patch1.37 KBmicahw156
#6 workbench_moderation-1548050-6.patch3.07 KBles lim
#5 workbench_moderation-1548050.patch2.21 KBles lim

Comments

hass’s picture

hass commented

If we could add an Edit operation link to the View it could also help a lot... I do not really understand why the "title" is the only colum that brings me to the node. If I need to review somthing, but I cannot as there are no links to the review it's pretty difficult to do a review. And a review process is not only "publish a node"... it's a lot more.

les lim’s picture

les lim
he/they
Primary language English
commented
Title: Moderation column has wrong wording » Change t('Moderate') to t('Change revision state')

"Moderate operations" is still pretty confusing, since it sounds like operations are what I'm moderating. I like "Change revision state", though.

les lim’s picture

les lim
he/they
Primary language English
commented
Title: Change t('Moderate') to t('Change revision state') » Change t('Moderate') to t('Change moderation state')

Or "Change moderation state", per the original post. That's probably better.

JacobSingh’s picture

JacobSingh commented

+100. Hugh usability improvement there.

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new workbench_moderation-1548050.patch2.21 KB

Patch attached.

les lim’s picture

les lim
he/they
Primary language English
commented
Title: Change t('Moderate') to t('Change moderation state') » Change t('Moderate') to t('Set moderation state')
StatusFileSize
new workbench_moderation-1548050-6.patch3.07 KB

Actually, "Set moderation state" is already a string in use elsewhere within the module. Let's use that for consistency.

hass’s picture

hass commented

How about adding a title (hover help...) for the status links, too?

les lim’s picture

les lim
he/they
Primary language English
commented
Version: 7.x-1.1 » 7.x-1.x-dev

#7: Different issue, perhaps?

hass’s picture

hass commented

I thought this is a usability issue, too :-)

les lim’s picture

les lim
he/they
Primary language English
commented

We can do all usability issues here in this thread, but only if you can guarantee me that there won't be any more usability issues after these two.

If so, hooray!

hass’s picture

hass commented
Priority: Major » Critical
Status: Needs review » Needs work
Issue tags: +D7 stable release blocker

Marking critical for release.

+++ b/workbench_moderation.node.incundefined
@@ -182,7 +182,7 @@ function workbench_moderation_node_history_view($node) {
+      $row['data']['moderation'] .= '<div class="moderation-actions">' . t('Set moderation state') . ': ' . drupal_render($moderate_form) . '</div>';

Fix

$row['data']['moderation'] .= '<div class="moderation-actions">' . t('Set moderation state: !moderation-actions-form', array('!moderation-actions-form' => drupal_render($moderate_form))) . '</div>';
hass’s picture

hass commented
Issue tags: -D7 stable release blocker
hass’s picture

hass commented

After several more user failures - I think we should replace the Moderate column links completly and add "Review" (link to node revision that requires the review), "Differences" (link to the differences, only if Diff module is installed). On the node we have the Workbench information block that allows users to publish the node or set the status back to draft.

For the Workflow of a review - only this makes sense to me, where the links from today make totally no sense as I should never publish something without a review.

micahw156’s picture

micahw156
he/him/his
commented
StatusFileSize
new 1548050-14.patch1.37 KB

Here is an alternative patch that combines this issue (changing 'Moderate' to 'Change to') which also includes the change proposed in #1732802: Rename "Current draft" to "Most recent revision" to avoid confusion and adds a <span> tag around the labels generated in workbench_moderation_workbench_block() so they can be styled.

I didn't see an easy solution for fixing the fact that workbench_moderation_workbench_block() ends up putting the <form> from $moderate_form inside an <em> element without a more major rewrite, but I have to say it bugs me a bit.

This doesn't resolve some of the issues hass raised in #13, so leaving it at needs work, but hopefully this can at least combine a couple of different usability issues surrounding this block.

pjcdawkins’s picture

pjcdawkins commented
Priority: Critical » Major

Related issue: #1265314: Clarify terminology for better usability (Delete, New draft, etc.)

(removed 'critical' status as per priority levels)

hass’s picture

hass commented
Priority: Major » Critical
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

^ LOL. So, I guess this line?

In contributed projects, it is up to each maintainer how they handle the critical status.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented 
+++ workbench_moderation.module	2012-11-01 17:23:13.000000000 -0400
@@ -1930,7 +1930,7 @@
-    $output[] = t('!label: <em>!message</em>', array('!label' => $message['label'], '!message' => $message['message']));
+    $output[] = t('<span class="label">!label:</span> <em>!message</em>', array('!label' => $message['label'], '!message' => $message['message']));
   }

Having trouble figuring out what purpose the t() function is even serving us there. It doesnt even haven anything translatable... which means, techically this should be a *themable* function not t().

hass’s picture

hass commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +Usability
StatusFileSize
new workbench_moderation_1548050+Change+Moderate+to+Set+moderation+state.patch3.12 KB

Roled new patch based on #6 with #11 fix included. RTBC.

hass’s picture

hass commented
StatusFileSize
new workbench_moderation_1548050+Change+Moderate+to+Set+moderation+state2.patch4.46 KB

Added prefix to the action links. Still RTBC.

hass’s picture

hass commented
StatusFileSize
new workbench_moderation_1548050+Change+Moderate+to+Set+moderation+state2.patch4.46 KB

Change to in action links sounds better. Column title is unchanged.

stevector’s picture

stevector
he/him
commented
Issue tags: +Workbench Sprint

Tagging for Workbench Sprint.

stevector’s picture

stevector
he/him
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks hass et al!

http://drupalcode.org/project/workbench_moderation.git/commit/971cbe1ee9...

hass’s picture

hass commented

Are these strings used in 2.x and are we running in regressions here?

hass’s picture

hass commented

Marked #1451254: "Moderate" link names are confusing as duplicate.

Automatically closed -- issue fixed for 2 weeks with no activity.