Closed (fixed)
Project:
Easy Social
Version:
7.x-2.8
Component:
Miscellaneous
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Apr 2012 at 01:35 UTC
Updated:
6 Aug 2012 at 04:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
samgreco commentedI just started seeing this as well. Worked previously.
Comment #2
iraszl commentedI can confirm. Facebook isn't working. Perhaps Facebook changed something and it broke the widget?
Comment #3
mrfelton commentedSame for me
Comment #4
Sms2luv commentedFacebook not working
Comment #5
petkove commented?locale= is a problem... probably just a temp fix:
includes/easy_social.widgets.inc - line 74 - //www.facebook.com/plugins/like.php?locale={$lang}&href CHANGE TO //www.facebook.com/plugins/like.php?href
--
http://eurobuecher.com
Comment #6
samgreco commentedThat indeed fixes it.
Comment #7
mrfelton commented#5 as a patch.
Comment #8
Sms2luv commentedPlease explain in detsil
Comment #9
Lula commentedHaving the same issue with Facebook too, though the above suggestion/patch to fix it, sadly didn't make any difference. Spent a few hours looking into this and I still can't work out if its a problem with the Easy Social module or from facebook's end.
If I set facebook to be 'iframe' it will display, allow me to 'like' it, and even add to the counter. On page refresh it then vanishes. With HTML5 and XFBML nothing is displayed at all at any point.
I took some time to look at the facebook like button page (where you would create basic like button code), and experimented with putting different URLs in there. One thing I did notice is that once a page is 'liked' via Easy Social, the like box will not even appear on the facebook 'like box' page (as the demo for your code, if you put the same url in there).
However, like I say I still can't work out if this is a facebook or Easy Social issue. I feel more inclined to say it's a facebook thing, but any advice on how to fix this (at least for the HTML5 version of it) would be really appreciated.
Comment #10
iraszl commented#5 fixes is temporarily, but the width of the Facebook button has changed, it now cuts of 48px. Where can we fix it to have it wider?
Comment #11
dgwebcreative commentedI can confirm this as well. Google and Twitter are working, Facebook is not showing up (though a space is left for it). Also the Facebook button is working when displayed in a block.
Comment #12
gowrann commentedThe patch from #7 fixes it so it appears.
Then to fix the right hand edge clipping you need to edit the CSS file:
/sites/all/modules/easy_social/css/easy_social.cssand change the px dimensions on the last line to 55px:
Flush the cache and all is well
Comment #13
LTech commentedI've applied the patch but facebook still isn't showing.
Comment #14
eric.chenchao commentedI found Facebook like box does not display when the language=en in the iframe request link caused by default language code 'en' generated when $lang = 'und'l passed by $node->language.
So the solution is simply change code in function _easy_social_facebook_langcodes
from
to
Comment #15
Sms2luv commentedI tried did not work
Comment #16
eric.chenchao commentedPlease check the Facebook iframe request link, if there is lang=en (if so it does display properly) or lang=en_US
Comment #17
xurizaemonDropping lang= like #5 / #7 works fine for me. But I suspect the intended fix is in _easy_social_facebook_langcodes(), and maybe we should expect 'und' not 'en' as the site default?
Added 'und' to FB and Twitter langcoders tho Twitter was already displaying fine. G+ and LI don't langcode yet.
Comment #18
Sms2luv commentedIt's working
Comment #19
plachI think the right fix here is making the fb widget follow the current page language, instead of following th enode language. This way the language on the label is consistent with the UI language.
Comment #20
xurizaemonPlach - is that in addition to the fix in #17, which deals with LANG=und? Or instead of?
Comment #21
plachIt's instead:
LANGUAGE_NONE(und) means there is no language specified, but we always have a language to rely on, which is the page language. IMO this would give us a more consistent beahvior: if I have a multilingual site with an untranslated node (say an english node) and I'm viewing it with a page language different from the node's one (say french), I expect to see the facebook label in french not in english.If you wish to address the default langcode value, we should replace the hardcoded
'en'withlanguage_default()->language, but IMO this is another issue.Comment #22
ganagus commentedI found this issue in the view handler as well. I changed the source to obtain the language from $node->language to global $language->language and it is working fine in a single or multilingual installations.
Comment #23
jegan2668 commentedIts working fine for me.
I used both patch #14 and #19
Comment #24
peximo commentedThis patch should fix the same bug for the views field.
Comment #25
sanook17 commentedStill having this issue.... any module updates going to fix this?
Comment #26
xurizaemon@sanook17, setting the issue from "needs review" to "active" moves it away from being resolved. That's not what you hoped to achieve.
(Please see Introduction to the Issue Queue which has two short videos introducing how things work, and/or Using the Issue Queue which has a more in-depth view of things. You'll find it much easier to get the results you want if you invest a few minutes to better understand the process.)
Irrespective of your level of familiarity, you can help get this issue fixed, and contribute to the Drupal community. Right now, the next step(s) to getting a fix in for this issue is to test and review the patch(es) posted (how?), and report back your results.
At the time of writing this, I'd recommend applying
both patches from #19 and#24.EDIT: Updated based on @eusonic's comment below.
Comment #27
eusonic commentedPatch #24 worked for me. Tested on node and in views.
FYI, patch #24 includes the fix in patch #19, so it's the only one you need.
Comment #28
develcuy commentedFacebook is displaying in my site, I'm using 6.x-1.4
Comment #29
lnunesbrThe patch #19 has been comitted, it's working like a charm. Thank u guys.