I did a commerce kickstart installation with some default product and then installed this module.
Then I set the "Product display" as "Auction display content"

Then I tried to place a bid on an already existing product and I got this error:
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'auction_timeout_timeout' cannot be null: INSERT INTO {field_data_auction_timeout} (entity_type, entity_id, revision_id, bundle, delta, language, auction_timeout_timeout) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6); Array ( [:db_insert_placeholder_0] => node [:db_insert_placeholder_1] => 2 [:db_insert_placeholder_2] => 2 [:db_insert_placeholder_3] => product_display [:db_insert_placeholder_4] => 0 [:db_insert_placeholder_5] => und [:db_insert_placeholder_6] => ) in field_sql_storage_field_storage_write() (line 448 of /home/xpete/public_html/commerce/modules/field/modules/field_sql_storage/field_sql_storage.module).

This happened because the timeout value was empty so I edited the product and set some timeout value and fixed the problem.
It's not exactly a a bug on this module but I think the module should do some validation on the timeout while placing a bid to make sure the timeout is not empty and haven't been exceeded.

Comments

farhadhf’s picture

Thanks, I added a some validations. Now if the timeout field has no value access callback of node/%node/placebid returns FALSE and shows a warning telling the user to set some value for timeout.

xpete’s picture

I saw you added the empty timeout validation but you didn't added an timeout exceeded validation on submit. I know the "place bid" tab i only showed before the timeout but if the user opens the form before the timeout he still can submit after the timeout.

farhadhf’s picture

Thanks :)
Added timeout validation to place_bid_form_validate() too.

xpete’s picture

Status: Active » Closed (fixed)

fixed