I think it would be helpful to know the IP and user agent of the last login.

This would enable the module to have a block that says "You last logged in from X.Y.Z.A IP address from a browser like this" or "You last logged in from X.Y.Z.A IP address from a browser %useragent_string".

What do you think? If you like the idea I can work on it.

CommentFileSizeAuthor
#4 1548168_login_history_more_data_4.patch9.83 KBgreggles
#3 1548168_login_history_more_data_3.patch8.08 KBgreggles
#2 1548168_login_history_more_data.patch8.08 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: log additional data about the login like IP and user agent » log additional data about the login like IP, user agent, and whether or not it was from a one-time login link
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new 1548168_login_history_more_data.patch8.08 KB

In addition to the feature, I ended up making a few small cleanups (whitespace, ending comments with a period). I think the biggest changes are to the menu definition so that it will have a description on admin/reports and so that there is a real permission associated with the path instead of "access_arguments" (which seems broken - my guess is only uid 1 could see this before).

Other than that the changes are pretty straightforward toward achieving this feature. Let me know if you have any questions/concerns/areas for improvement.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 1548168_login_history_more_data_3.patch8.08 KB

This patch fixes some parse errors in the last caused by copy/paste without cleaning it up.

I haven't actually tested the upgrade path on this...

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: log additional data about the login like IP, user agent, and whether or not it was from a one-time login link » log additional data about the login like IP, user agent, and whether or not it was from a one-time login link (and a block)
StatusFileSize
new 1548168_login_history_more_data_4.patch9.83 KB

Ok, one more idea....putting in a block to show your last login time.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

And committed - http://drupalcode.org/project/login_history.git/commit/28ccb13

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.