attached patch converts the locale deletions to the deletion API. tested as working.

CommentFileSizeAuthor
dapi_locale.patch3.8 KBhunmonk

Comments

Crell’s picture

Crell commented

Code looks clean visually (at least at 2 am). I'm afraid my knowledge of both delete API and locale is too limited to do more than that. Sorry hunmonk. :-)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Code looks good. I have two questions though, which have roots in how few insight I have about the deletion API :)

1. _submit functons were converted to _post functions to protect them from being called by the form submit system? Or what is the reason behind this?
2. How to go about implementing conditional deletions. It occured to us lately, that it is not as simple as removing source strings and translations, if plural forms are involved (because plural forms are stored in a linked list format, so we should not break the chain by arbitrarily removing elements from the chain). There conditionals would be required to decide on deleting or not. I don't see how this system would allow that, but we will need a bugfix for that soon. (This is buggy in Drupal 6.x-dev now).

hunmonk’s picture

hunmonk commented
Status: Needs review » Reviewed & tested by the community

submit functons were converted to _post functions to protect them from being called by the form submit system? Or what is the reason behind this?

easy answer -- the workflow for deletions, in brief, is now:

  1. build the entire deletion process
  2. present that to modules
  3. optionally confirm
  4. execute the deletions

because all deletion data is built first, we have to separate out deletion actions that logically happen after deletion -- otherwise you get things like user messages saying "the node has been deleted" even though a module aborted the deletion.

How to go about implementing conditional deletions.

i haven't seen a situation yet where there isn't enough data available to calculate the conditional deletions before any data actually starts getting deleted. calculating them *might* be a bit more involved since you can't just simply examine what's left in the database, but should still be possible. the main point of the deletion API's existence is "show me what you're going to to before you do it", which in certain cases might involve a bit more work. i can tell you i've converted over pretty much all of core to this workflow, and haven't had any problems with it.

since i've already tested this patch, and it's gotten code reviews, i think it's RTBC.

hunmonk’s picture

hunmonk commented
Assigned: hunmonk » Unassigned
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Closed (won't fix)

Deletion API was rolled back.