Posted by apsivam on June 27, 2007 at 3:55am
| Project: | Path redirect |
| Version: | 6.x-1.0-beta6 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This patch will set a warning message to users so that they can update their bookmarks or correct links.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| path_redirect_warning_message.patch | 552 bytes | Ignored: Check issue status. | None | None |
Comments
#1
I just applied this in my personal website
you can see this in action here
www.apsivam.in/tips/no_www_to_www_redirection this will take you to www.apsivam.in/guides/webmaster/www_redirection with the info message set
#2
I like this, but I think this should be a setting for the site administrator. Having a drupal_set_message() on the page will cause a full page load when page caching is turned on. This could be a performance problem.
Also there are many situations where the administrator would not want to the message to show up (tinyurl style). I sort of think that this should be a per-redirect option with a checkbox for "display redirect message" or even possibly a text field for the admin to be able to enter their own custom text.
#3
Definitely a good idea. Let me come up with new patch.
#4
Here is an updated patch that includes a settings form and some code for #167265.
#5
Seems to be working fine. I committed this without the nodeapi stuff and with a couple of minor corrections.
#6
Automatically closed -- issue fixed for two weeks with no activity.
#7
This doesnt work flawlessly in v.6, if the message is turned on an extrmely ugly 404 is shown when "Display a warning message to users when they are redirected." is shown:
In the v5 is was a very polite
#8
#9
This is basically the same as the D5 version, so if there's something to be improved, please don't re-open very old closed issues.