Edit and delete links should be hidden for locked fields

I recently ran across this bug, and it's a very disconcerting UI bug in my opinion. The patch probably needs a test.

field_ui_locked_operations.patch queued for re-testing.

field_ui_locked_operations.patch queued for re-testing.

Here are some tests.

Makes sense, needs re-roll though

The form callback was moved out of the field_ui.admin.inc file, so we moved the fix accordingly, also rerolled the test.

#6: 1549506-field_ui_locked_operations-6.patch queued for re-testing.

+++ b/core/modules/field_ui/lib/Drupal/field_ui/Tests/ManageFieldsTest.phpundefined
@@ -342,6 +342,39 @@ function testDeleteField() {
+   * Test that Field UI respects locked field

Nitpick, needs a full stop.

+++ b/core/modules/field_ui/lib/Drupal/field_ui/Tests/ManageFieldsTest.phpundefined
@@ -342,6 +342,39 @@ function testDeleteField() {
+    field_create_field($field);

field_create_field is deprecated, should be entity_create('field_entity', $values); now.

+++ b/core/modules/field_ui/lib/Drupal/field_ui/Tests/ManageFieldsTest.phpundefined
@@ -342,6 +342,39 @@ function testDeleteField() {
+    field_create_instance($instance);

Same here, should be entity_create('field_instance', array $values));

Looks good other than that, after that it's RTBC!

rerolled, also removed the t() strings as we don't use them anymore in tests.

duh

Committed/pushed to 8.x, moving to 7.x for backport.

Removing some tags, will re-roll later this week

I tried to port the patch to D7 (see attached), however I'm a bit stuck at the test part.

For the test part I replaced the entity_create() calls for field_create_field(), since AFAIK entity_create() is part of the Entity API module in D7. I assumed one should be able to run tests without any contrib modules installed.

Anyway, I'm just starting with contributing to Core, so I find it a bit hard. Can someone point me in the right direction? E.g. how can I properly debug the whole testing part?

I think I made a bit of progress. However the line

$this->assertTrue(in_array('Locked', $locked), 'Field is marked as Locked in the UI');

is still failing in my manual test runs. And I don't understand why...

When I check the verbose test results, in the area for edit and delete links are both marked as "Locked". So, I guess that's what should happen. Next to the label 'Locked Field' should there be any other indication that the field is locked?

New patch attached.

+++ b/modules/field_ui/field_ui.test
@@ -378,6 +378,38 @@ class FieldUIManageFieldsTestCase extends FieldUITestCase {
+    $locked = $this->xpath('//tr[@id=:field_name]/td[5]', array(':field_name' => $instance['field_name']));
+    $this->assertTrue(in_array('Locked', $locked), 'Field is marked as Locked in the UI');
+    $edit_link = $this->xpath('//tr[@id=:field_name]/td[5]', array(':field_name' => $instance['field_name']));
+    $this->assertFalse(in_array('edit', $edit_link), 'Edit option for locked field is not present the UI');
+    $delete_link = $this->xpath('//tr[@id=:field_name]/td[6]', array(':field_name' => $instance['field_name']));

The id in the html is 'field-test' (with a hyphen). So we could pass $instance['field_name'] in drupal_html_class().
Also the edit and delete td indexes in the XPath were not correct.

Here's a reroll.

Thanks for the feedback @herved!

I was trying to test it. But i couldn't find any steps to reproduce. If someone can add the steps to test this, it would be very helpful.