This is the opposite of #361471-43: Global $user object should be a complete entity

We should rename global $user into $session or similar. That's what is is, {session}.

Admittedly, for convenience, {users} and {users_roles} is tacked onto it, but selling that as $user is the bug in the first place.

Let's see what breaks.

CommentFileSizeAuthor
drupal8.user-session.0.patch3.43 KBsun

Comments

Status: Needs review » Needs work

The last submitted patch, drupal8.user-session.0.patch, failed testing.

robloach’s picture

robloach
he/him
commented

I like this idea. It'll transition quite nicely with #335411: Switch to Symfony2-based session handling and #1545680: Convert all uses of $_SESSION to symfony session syntax.

cosmicdreams’s picture

cosmicdreams commented
Status: Needs work » Needs review
Issue tags: -Framework Initiative, -API change, -API clean-up, -Dependency Injection (DI)

drupal8.user-session.0.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Framework Initiative, +API change, +API clean-up, +Dependency Injection (DI)

The last submitted patch, drupal8.user-session.0.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented

In #335411: Switch to Symfony2-based session handling there was some brief discussion of putting the {users} and {users_roles} information actually into $_SESSION itself, so $_SESSION['user'] or similar. Is it worth trying that here?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

I'd rather move in small steps. Apparently, the patch in #0 wasn't even able to install Drupal, which most likely means that the dependencies on {users} fields on global $user already start in the installer... :(

We need to figure out what exactly that is.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

The Drupal installation failures in the patch in #0 will be resolved via:
#782672: Loosen the coupling between the user module and the installer/maintenance theme
#347988: Move $user->data into own table

d34dman’s picture

d34dman commented
Status: Needs work » Needs review
Issue tags: -Framework Initiative, -API change, -API clean-up, -Dependency Injection (DI)

drupal8.user-session.0.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal8.user-session.0.patch, failed testing.

jp.stacey’s picture

jp.stacey commented
Issue summary: View changes

Global $user no longer exists, since #2328645: Remove remaining global $user. Should this therefore be closed as "cannot reproduce"?

fabianx’s picture

fabianx commented
Status: Needs work » Closed (duplicate)

Yup, thanks for the ping, this is closed (duplicate).