Using this issue for changes related to the rest of the update system (update status etc...)

Comments

Crell’s picture

Crell commented

Looking at the branch:

-  readfile("$path/$project_name.$availability_scenario.xml");
+  $output = file_get_contents("$path/$project_name.$availability_scenario.xml");
+  if (!$output) {
+    $output = '';
+  }
+  return new Response($output, 200, array('Content-Type' =>  'text/xml; charset=utf-8'));

I don't know how big those XML files are, but that would probably be a good use case for a StreamedResponse:

https://github.com/symfony/HttpFoundation/blob/master/StreamedResponse.php

We're already using it in the kernel branch for private file handling.

katbailey’s picture

katbailey commented
Status: Active » Needs review

OK, made the change suggested above - see http://drupalcode.org/sandbox/Crell/1260830.git/commitdiff/c4cae4e1ef7de....

There were three outstanding fails and I have just now confirmed that these will be fixed by #1183208: Remove variable_get('clean_url') and switch to index.php/path pattern for dirty URL support - they are due to update module's hook_init(), which begins:

  if (arg(0) == 'admin' && user_access('administer site configuration')) {
    switch ($_GET['q']) {
Crell’s picture

Crell commented
Status: Needs review » Fixed

Great. I cherry-picked the last commit over to the kernel branch and pushed. Thanks, Kat!

Removing the feature branches now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.