Error "Undefined index... in _filter_tips()" when user input is sanitized by a text format they don't have permission to use. [#1551064]

Setting the sanitize source format to a text format that the user doesn't have permission to causes the error:

Notice: Undefined index: [myfilter] in _filter_tips() (line 1011 of [mysite]/modules/filter/filter.module).
Notice: Trying to get property of non-object in _filter_tips() (line 1015 of  [mysite]/modules/filter/filter.module).
Notice: Trying to get property of non-object in _filter_tips() (line 1016 of  [mysite]/modules/filter/filter.module).

The error disappears when I add permission to use [myfilter] to the user's role.

Comment	File	Size	Author
#3	sanitizable-theme_filter_tips_problem-1551064-3.patch	1.36 KB	maurizio.ganovelli

Comments

Comment #1

RobW commented 27 April 2012 at 18:32

Yep, problem is calling theme('filter_tips', ...) on filters that a user's role doesn't have permission to use in _sanitizable_tips.

I don't know how you'd get around the permission system here, so I can't roll a good patch to fix. For now I'm just killing the filter tips and forgetting about it.

function _sanitizable_tips($filter, $format, $long = FALSE) {
  return t('The text will be formatted before storage using the following settings.')
    // Commenting this guy out removes the error (and the filter tips)
    //. theme('filter_tips', array('tips' => _filter_tips($filter->settings['format'], FALSE)))
    ;
}