Just need to port the code from D6.

CommentFileSizeAuthor
#7 1551156-project_issue_maintainers_tests-7.patch9.96 KBmikey_p

Comments

mikey_p’s picture

mikey_p commented
Issue tags: +project, +drupal.org D7

Tagging.

mikey_p’s picture

mikey_p commented

Mostly committed.

mikey_p’s picture

mikey_p commented
Status: Active » Needs work
Issue tags: +sprint 1

Needs working tests to mark as completed.

mikey_p’s picture

mikey_p commented

This will need to tie into: #1551248: Port project-specific "Assigned" functionality to D7

mikey_p’s picture

mikey_p commented

I am looking through the maintainers code to make sure it's working properly, in all the places it should be checked and it seems that the only place it's used is in the "Assigned" field for issues. Does that sound correct?

dww’s picture

dww
we/he/they
commented

In project_issue, yes, that's right. The "maintain issues" perm is just about being able to assign stuff to each other.

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review
StatusFileSize
new 1551156-project_issue_maintainers_tests-7.patch9.96 KB

Here's the test ported over. They are a running but not 100% passing since these also check that maintainers show up at the correct place in the assigned field, which is not yet ported (see #1551248: Port project-specific "Assigned" functionality to D7).

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

#7 looks great to me. Didn't try running it locally but I trust you. Fire at will.

Thanks!
-Derek

mikey_p’s picture

mikey_p commented
Status: Reviewed & tested by the community » Fixed

Committed.

senpai’s picture

senpai commented
Issue tags: +sprint 2

.

Automatically closed -- issue fixed for 2 weeks with no activity.