Getting the following notices with 7.x-3.0-rc2:

Notice: Undefined index: src in theme_admin_menu_icon() (line 924 of /path/to/drupal/sites/all/modules/contrib/admin_menu/admin_menu.inc).
Notice: Undefined index: alt in theme_admin_menu_icon() (line 924 of /path/to/drupal/sites/all/modules/contrib/admin_menu/admin_menu.inc).

Odd thing is that this is only showing up occasionally, on first page view (when returning to a site when logged in with admin_menu), but not when flushing caches. Also appears to only happen when page caching is enabled (though not 100% sure on that).

The theme_admin_menu_icon() function now takes the $variables param which was introduced in #1376852: Cached icon breaks HTTPS pages but it appears src and alt are not being consistently set.

Comments

ramsegal’s picture

ramsegal commented

Happens to me too

dflitner’s picture

dflitner commented

I'm seeing this behavior as well though I can't seem to make it happen now that I'm trying to force it to appear. This exact message appeared when I first went to my site today and was also on the Status Report page. After I cleared the cache I haven't see it reappear, even after closing the browser and reopening it.

I turned off the "Cache menu in client-side browser" setting in the Admin Menu config just to see if that helps at all. I haven't done anything with the rest of my site caching so it's set at whatever the default D7 vanilla install settings are.

Chrome on Win7 here, if that helps.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-3.0-rc2 » 7.x-3.x-dev

I'm getting this even with the latest 7.x-3.x from Git on a fresh install of core + admin_menu only.

Notice: Undefined index: src in theme_admin_menu_icon() (line 927 of /home/dave/Dropbox/Projects/drupal7dev/sites/all/modules/admin_menu/admin_menu.inc).
Notice: Undefined index: alt in theme_admin_menu_icon() (line 928 of /home/dave/Dropbox/Projects/drupal7dev/sites/all/modules/admin_menu/admin_menu.inc).

Looking at devel/theme-registry it appears that template_preprocess_admin_menu_icon() is not getting registered as a preprocess function and therefore is never run, which defines $variables['src'] if it is not defined.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Hrm, it appears I might not have cleared by theme registry after updating (because update.php didn't do it via drush).

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Postponed (maintainer needs more info)

For anyone having this problem, try running update.php or clearing your site's theme registry. That should fix it.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

Yep, I think Dave Reid has it, without a theme registry clear (which drush updb nor aegir seem to do on module update) this error is present, but after a theme registry clear (or full cache clear) it goes away.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Postponed (maintainer needs more info) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.