I just installed the latest dev of the module and tried adding a dummy menu item to an existing menu. I immediately got this error:

Warning: Parameter 1 to content_menu_menu_form_handler_dummy() expected to be a reference, value given in content_menu_menu_overview_form_submit_extended() (line 427 of /mysite/sites/all/modules/content_menu/content_menu.menu_admin.inc).

Comments

cpelham’s picture

cpelham commented

If it makes any difference, I have a multi-lingual site, Drupal 7.12.

drshearer’s picture

drshearer commented

I received the same error and I don't have a multi-lingual site.

leschekfm’s picture

leschekfm commented
Priority: Normal » Major

I get the same error regardless of which type of menu item I want to create.
As this prevents the creation of any menu link I think the priority can be set to major.

danielnolde’s picture

danielnolde commented
Status: Active » Needs review

Hm, i don't get this PHP warning.
But they seem to be logical, given the -by-reference argument declaration an the way the target type handlers are called via call_user_func which does not respect the by-reference calling. Important bug report, anyway - thanks guys!
Find in current dev the first attempt to fix "expected to be a reference" PHP warning by making argument in target type handlers not call-by-reference anymore (not needed, anyway).

=> Please review! <=

drshearer’s picture

drshearer commented
Status: Needs review » Fixed

I reinstalled the module and it seems fine now. No error.

leschekfm’s picture

leschekfm commented

Updated and 'URL' and 'dummy' link creation now works.
'Existing content' and 'New <CT>' work on a fresh installation, on an other site we're developing these are broken.
I will have to look what's the issue there, but I think that is not related.

Edit: 'Existing content' works now without me doing anything ^^,
The issue with 'new <CT>' is described in #1561182: Creation of 'New <multi worded type>' link redirect broken

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.