At http://2012.drupalday.es there was a Simpletest workshop were we worked on adding tests to this module.

A patch with a functional test for this module is attached in the following comment.

CommentFileSizeAuthor
#1 site_map-1551940-1-add-functional-tests.patch2.61 KBjuampynr

Comments

juampynr’s picture

juampynr commented
Status: Active » Needs review
StatusFileSize
new site_map-1551940-1-add-functional-tests.patch2.61 KB

Here is the patch. It enables and configures site_map and then checks that a new node with a menu entry at Main menu gets listed at /sitemap.

darrell_ulm’s picture

darrell_ulm commented
Assigned: Unassigned » darrell_ulm

Thanks, will take a look at it.

juampynr’s picture

juampynr commented

Did you have a chance to have a look at this? I was hoping that it would be useful after applying patches in order to ensure the module's stability.

darrell_ulm’s picture

darrell_ulm commented

juampy ,

Thanks for reminding us! Yeah, I'll keep this on my my radar over this week and try to get to it ASAP.

Thanks again.

darrell_ulm’s picture

darrell_ulm commented

juampy,

Yes, patch worked fine and test works and code looks good. Applied to the current 7.x-1.x development head.

http://drupal.org/node/9099/git-instructions/7.x-1.x

Still need to push a 7.x-1.x-dev release, which has some other patches.

Thanks!

juampynr’s picture

juampynr commented

@darrellulm, great! I will see if I can add further tests for it.

darrell_ulm’s picture

darrell_ulm commented
Status: Needs review » Fixed

This is pushed to head, so moving to fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.