Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I noticed there is a t() missing around the home trail, dunno if target should be / or front, you decide.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | home_link-1553316-3.patch | 1.4 KB | deggertsen |
| #3 | 0001-Issue-1553316-home-link.patch | 23.88 KB | fgm |
| #2 | 0001-Issue-1553316-home-link.patch | 4.76 KB | fgm |
| #1 | 0001-Issue-1553316-Home-trail-was-not-translated-and-home.patch | 4.61 KB | fgm |
| breadcrumbs_by_path-home_trail_is_not_translated-1.patch | 446 bytes | XerraX |
Comments
Comment #1
fgmRerolled on today's head, and added coding standards compliance.
Comment #2
fgmRerolled on top of latest version 7.x-1.0-alpha6. Please review.
Comment #3
fgmTwo other improvements:
- do not throw notices is some parent of the current path is actually invalid, as happens with advanced_help giving help/* paths for pages instead of admin/help/*
- remove LICENSE.txt from commit: it is placed there by the packaging process when rolling releases, and must not be committed
- remove packaging info from commit: same reason, they are added by the packaging process, and mess version detection for update.module otherwise.
Comment #4
deggertsen commentedI have rerolled the patch against the current dev version (Feb 16 2013) and to only include the items necessary to fix this particular issue. We may want to open a separate issue to fix the coding standards issues. I'm slightly perplexed as to why this hasn't been committed already... Hopefully this patch helps. Thanks to fgm for the fix!
Comment #5
deggertsen commentedOn second look, the patch I just posted may still have some unnecessary changes with relation to this issue, but I still think this patch should be committed.
Thanks
Comment #6
opdaviesCommitted to 7.x-1.x-dev. Thanks all! :)
Comment #7.0
(not verified) commentedremoved not allowed tags