Burstn

welcome,

I'm afraid this project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project.

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

Please use drupal_add_js's settings method for inserting your variables inline.

Make sure all human readable text is translatable by t() (also 'My Latest Burstn Photos')[, except within hook_menu() and watchdog()].

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxlittlecoding1537278git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

Hello,

I think it was cool if the content of the block stayed a renderable array.
In this way, another module could modify this content.

Regards,

Hello LittleCoding,

I am a fellow applicant and have been reviewing your project towards geeting a review bonus for my application.

Automatic review:

- ventral PAreview comes up clean

Manual review:

Module downloads and installs OK.

'needs work' IMHO:

- .module, line 209 - 'My Latest Burstn Photos': block subject should be consistent with the context of what's being displayed (all, popular, personal)

- I'd buy on the idea from olmeta.david about separating the 'making' of the list from the viewing. You might implement a theme that prepares an array of items and returns HTML via theme_item_list(). Then your burstn_block_view() to call such theme, and other modules could call the theme as well.

Food for thought - just ideas

- from a pure usability POV, I'd like to see pagination (i.e. next/previous set of pictures) within the block - your link to 'More Burstn' redirects to burstn.com which is not what I was expecting when I clicked there (i.e. I was expecting to get more photos displayed on the block)

- also I believe with some js you may dynamically change height/width of the .burst css, and make such setting a parameter in the configuration

Overall, looks like 'needs work' for me.

Regards

mondrake

One more thing:

try to be consistent between .info entry
package = Media

and configuration menu
admin/config/services/burstn

This way the module is listed under 'Media' section and configured in 'Web services' section - I suggest to change menu to
admin/config/media/burstn

mondrake

Idle Application

This thread has been idle, in the 'needs work' state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and marking it as closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open the thread and set the issue status to "needs work" or "needs review", depending on the current status of your code.