Comments

geerlingguy’s picture

Status: Needs review » Reviewed & tested by the community

Looks like MIT license, code is proper size.

geerlingguy’s picture

Status: Reviewed & tested by the community » Fixed

Added to whitelist: http://drupal.org/node/1570862

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

japerry’s picture

Status: Closed (fixed) » Reviewed & tested by the community

Backbone and Underscore recently changed their urls for their libraries. This should be updated to reflect the following entries:

^http://documentcloud\.github\.io/underscore/underscore.+$
^https://github\.com/jashkenas/underscore/.+$

greggles’s picture

@japerry - there's a third url in the whitelist - ^https://github\.com/documentcloud/underscore/zipball/master - should that one also be updated and if so how?

geerlingguy’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)
japerry’s picture

Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

yah I see that now, I guess they were being extra verbose for underscore. For consistency we should update that one as well.

Should look like:

^https://github\.com/jashkenas/underscore/zipball/master

greggles’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.