Closed (fixed)
Project:
Drupal.org Library Packaging Allowlist
Component:
Whitelist request
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Apr 2012 at 05:58 UTC
Updated:
14 Sep 2019 at 08:34 UTC
Jump to comment: Most recent
Comments
Comment #1
geerlingguy commentedMIT License, code is proper size.
Comment #2
geerlingguy commentedAdded to whitelist: http://drupal.org/node/1570858
Comment #3
ethanw commentedJust a note that the Backbone module includes a makefile and library definition for Backbone.js. Currently it's a tad heavy, and we need to add a minimal one to use by default, but it is a nice option as a standard.
Comment #5
japerryBackbone.js URL changed, see #2063467: Backbone release URL needs to be updated for more details.
https://github.com/documentcloud/backbone has changed to https://github.com/jashkenas/backbone
Still under MIT license.
Comment #6
gregglesI confirmed the redirect that jrbeeman mentions in #2063467: Backbone release URL needs to be updated and updated the url based on that.
I removed the line:
which might break some stuff. If it does...sorry and let's see about whether that needs to be reverted?
Comment #7
gregglesActually added back the documentcloud.github.com url as it seems to be a real source in use by backbone.module.
https://drupal.org/node/1570858/revisions/view/2801507/2801513
Comment #8
japerryAlso should have the production release js file whitelisted:
Thus there will be two entries, one for the nightlies and one for the release.
Comment #9
gregglesIndeed, the documentcloud.github.io is redirecting to documentcloud.github.com
Comment #11
kreynen commentedI'm in the process of updating all of the GitHub whitelist entries to roll with the changes GitHub is making and standardize on the regular expressions we are using to make the Whitelist easier to maintain. When looking at https://www.drupal.org/node/1570858, I don't believe ^http://documentcloud\.github\.io/backbone/backbone.+$ actually matches an actual resource anymore and should be removed... but I've left it for now.
^https://github\.com/jashkenas/backbone/.+$ was removed because it is covered by the more inclusive ^(git|https|http)://github\.com/jashkenas/backbone[.git/].+$
We are adding patterns to allow raw.githubusercontent.com codeload.github.com on all GitHub entries. The current theory is that whitelist packaging can fail on Drupal.org if the URL in the .make is using https. We are not recommending that maintainers use a URL that isn't being redirected.
I've also added patterns for the Development and Production downloads from http://backbonejs.org/. The "Edge Version" links to https://raw.githubusercontent.com/jashkenas/backbone/master/backbone.js which is already covered in ^(https|http)://raw.githubusercontent\.com/jashkenas/backbone/.+$
I'm changing this to Needs Review to confirm there is no way anyone could actually be using ^http://documentcloud\.github\.io/backbone/backbone.+$ to get backbone.js and that it should be removed.
Comment #12
gisleI am cleaning up all the old "Needs review" entries to make the issue queue less messy. This hasn't been touched in 5 years. Don't see any problems with this and moving to "Fixed". Anyone objecting have two weeks to reopen before is is automatically closed.