Closed (fixed)
Project:
Ubercart
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
30 Apr 2012 at 07:57 UTC
Updated:
12 Jan 2016 at 18:52 UTC
Jump to comment: Most recent
Comments
Comment #1
Neo13 commentedWill this patch be implemented in core?
Comment #2
longwaveYes, if someone (like you!) tests it and confirms that it works.
Comment #3
Neo13 commentedIf you could please post it as patched module in .zip file I would be happy to test it.
Comment #4
longwaveSee http://drupal.org/patch/apply to learn how to apply patches.
Comment #5
Neo13 commentedI have tried, but I wasnt succesful in patching uc_order.module and just uc_product was patched. If you cant post .zip then I will try again later.
Comment #6
Neo13 commentedThe problem was that I wasnt using dev version of Ubercart. Now I patched it and it works like a charm :)
Comment #7
Neo13 commentedComment #8
longwaveCommitted.
Comment #10
natukForgive me for reopening this but I think there is a problem with this function:
What happens is that if this action is used in VBO to add multiple items in the cart for an order, in many cases we would want the customer to land in the cart page after submitting the form. This can be done, for example, with the
?destination=carton the url. VBO is supposed to honour the destination parameter after submission of the form. However, it seems that only the first item of the selected ones is added to the cart. I think this is because of the default parameters of uc_cart_add_item. The sixth parameter is by default set toTRUEand I think that when the function discovers the ?destination=cart it jumps to it straight away and does not let VOB to carry on with processing the rest of the items.If instead we write:
(sixth parameter is
FALSE) the problem disappears. I.e. there is no redirection by theuc_cart_add_itemand therefore VBO carries on and redirects when done.Thanks to Lee Rowlands for the pointer.
Comment #11
longwaveCommitted the improvement in #10, thanks.
Comment #13
DrCord commentedThis seems to have been put into VBO core.
Comment #14
truyenle commentedpatch already committed to version 7.x-3.9. Work for me.