Verizon USA cleanup & question...

Hello..

You have an excellent framework here, and I'm looking to help. :)

First off, a couple things I noticed with the Verizon US cleanup. I tested things w/ three different phone models through their MMS service.

1) The subject given to the MMS message is the mail subject. This must have changed as I saw you had the following code to replace the "generic subject" that you saw:

$node->title = truncate_utf8($body, 60, TRUE, TRUE);

I think that could be safely removed for Verizon MMS US. I just put in a few different rules to take care of users being lazy (or dumb :) ):

      // Lets clean up if the author just puts the title in the body
	  if (empty($node->title) && !empty($node->body) && strlen($node->body) <= 60) {
		$node->title = $node->title = truncate_utf8($body, 60, TRUE, TRUE);
		$node->body = "";
	  }
	  
	  // What if there is no title and just a longer description
      if (empty($node->title) && !empty($node->body) $node->title = truncate_utf8($body, 60, TRUE, TRUE);
      
      // OK how about a really lazy author
	  if (empty($node->title) && empty($node->body)) $node->title = "Mobile Submission";

2) I see you saw a TXT attachment of the body named "smiltextpartfilename0.txt" and a question about that being phone dependent. Well, it is. My Motorola Q attaches one thats $random_number$.txt, and the other phones I tried didn't attach anything. I just decided to strip out all the 'text/plain' inclusions with:

      // Get rid of extra text attachments
      foreach ($node->mailsave_attachments as $key => $file) {
        if ($file['filemime'] == 'text/plain') {
          unset($node->mailsave_attachments[$key]);
    	}
      }

Now for the good news :) I have a plugin working for mailsave that turns the attached JPGs into CCK imagefied items. At the moment it works fine, but a few things are hardcoded still which I need to replace.

The one thing that has me puzzled is that in looking at your mailsave_to_image example it seems that $node->type should be set at that point. However I don't see it in $node, and I would need that to lookup some CCK information. Should that always be set at that point? or only if the type has been forced through mailhandler tags?

Thanks again...

-James