Closed (duplicate)
Project:
Drupal core
Version:
6.x-dev
Component:
base system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Jun 2007 at 21:48 UTC
Updated:
29 Jun 2007 at 03:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
mfbAlso fix up all occurrences of format_date() in core.
Comment #2
karens commentedThis goes with the patch at http://drupal.org/node/11077, which creates the date_handle_timezones() function and other necessary infrastructure.
Comment #3
mfbTry to fix comment re: PHP version. Still not clear precisely which point version of PHP we are requiring.
Comment #4
karens commentedThe reason for creating date_handle_timezones() is that we can tweak it as we figure out exactly what versions we require to do what we want to do. I would keep the document generic, i.e. 'Using native timezone handling mode' instead of naming a specific version.
Also, I see you omitted the 'r' format from the native timezone handling code and added it to the non-translated dates. You have to run that one back through format_date() as is done with the offset handling because there are parts of the format that need translating.
Have you done any testing to see if the dates are correctly computed?
Comment #5
mfbThanks for catching that.
The patches do work in my testing. However, it might be good to merge them into one patch if we can't get enough people to test them otherwise.
Comment #6
mfbI have merged the two patches, you can find it at http://drupal.org/node/11077
Comment #7
webchick