In "drush_l10n_update" function the mode option is retrieved either as "keep" or "overwrite" but "l10n_update_import_file" function expects an integer (0/1).
The attached patch fixes the issue

CommentFileSizeAuthor
#3 l10n_update-drush-translate-mode-3.patch2.1 KBsutharsan
#2 translate-mode-option.keep-override-default.patch886 bytesigor.ro
translate-mode-option.patch.txt874 bytesralf57

Comments

sutharsan’s picture

sutharsan commented
Priority: Major » Normal
Status: Active » Needs review
igor.ro’s picture

igor.ro commented
StatusFileSize
new translate-mode-option.keep-override-default.patch886 bytes

Hello.

For keep mode correct to use LOCALE_UPDATE_OVERRIDE_DEFAULT instead of LOCALE_IMPORT_KEEP

Here is the patch.

sutharsan’s picture

sutharsan commented
Version: 7.x-1.0-beta3 » 7.x-1.x-dev
StatusFileSize
new l10n_update-drush-translate-mode-3.patch2.1 KB

Localization Update has three update modes, so you are both right. New mode 'replace' added. Help tekst updated.

sutharsan’s picture

sutharsan commented
Issue tags: +needs backport to 6.x

Committed to 7.x. I like to see this backported to D6. It may work without change, but at least requires to be tested.

hass’s picture

hass commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)
sutharsan’s picture

sutharsan commented
Issue summary: View changes
Status: Patch (to be ported) » Fixed

Cleaning up the issue queue. Feel free to work in this issue, re-open the issue if you are working on a 6.x-1.x port of this patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.