Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.wwwebernet reported some problems with the link separator we've got hard-coded in here. we should probably just use theme('links') for this. already committed to the sandbox for D6, but figured a backport was in order. any objections?
| Comment | File | Size | Author |
|---|---|---|---|
| update_status_theme_links.patch.txt | 1.11 KB | dww |
Comments
Comment #1
merlinofchaos commentedYea, theme('links') has a way of looking really ugly since it was recoded for Drupal 5. I don't really like it. THat's why I didn't use it.
Comment #2
dwwhrm. that seems like a gripe for the themes were it looks bad, no? this is exactly what theme functions are for, right?
not sure what's more important here: forcing this to look just like we want it to, assuming we know best, or using the theme tools that might end up creating something ugly, but that give people flexibility to make it look however they want. this appears to be the same debate as http://drupal.org/node/155227.
Seems I've been aiming for the "use whatever the themers say" approach, and you're from the "we know best" approach. So far, looks like you're the wiser of the two of us. ;)
*shrug*
-derek
Comment #3
merlinofchaos commentednot sure what's more important here: forcing this to look just like we want it to, assuming we know best, or using the theme tools that might end up creating something ugly, but that give people flexibility to make it look however they want.
In general, though, they don't. Theme('links') is a global thing, and is generally set up to work within the theme, but we've got a pretty specific look here, and letting one tiny piece of it be changeable in the theme when the rest of it *isn't* changeable (we have fixed colors, widths, font sizes) is very funky. Something that can only be changed a LITTLE is actually more frustrating than something that can't be changed at all.
Also, theme('links') has taken to using LI and float tricks to do horizontal lists, so your separator ends up being a background image. That's blah, oo.
Comment #4
dwwAfter discussion in IRC, we all decided not to commit this. wwwebernet couldn't really come up with a compelling reason, and couldn't remember the details of the problems he suggested originally. ;) theme('links') doesn't use *any* separator at all in garland, for example, just more space. There's just too much chance that some theme will do something funky site-wide with theme('links') that ends up making this look stupid, so forget it.