Since upgrading from 5.0 dev to 5.0 release, the main navigation menu does not adjust its position when the admin menu is displayed. It may be that I've incorrectly merged the release changes into my build but I don't think so.

To fix the issue, a 'position: relative;' needs to be added to #main. Then the comment below about positioning the navigation relative to #main's padding in responsive-sidebars.sccs is correct:

/*
 * Navigation bar
 */
...
    top: 0; /* Move the navbar up inside #main's padding. */
CommentFileSizeAuthor
#2 zen-make-main-relative-1554848-2.patch3.25 KBAnonymous (not verified)

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Priority: Normal » Critical

Doh!

I had to update to Zen Grids 1.1 in this issue: #1546800: box-shadow doesn't work on grid contained elements and that included this bug fix: https://github.com/JohnAlbin/compass-zen-grids/issues/1

And I didn't properly test this. My navigation bar hid underneath the admin toolbar and I totally didn't notice it.

Nigel, how would you like to roll a patch to fix this? position: relative needs to be added to the layout files.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new zen-make-main-relative-1554848-2.patch3.25 KB

I patched the generated CSS as well for good measure!

Argus’s picture

Argus commented

Yeah seems to work fine that patch.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Navigation vertical position does not compensate for administration menu. » Vertical positioning of navigation is wrong/too high
Version: 7.x-5.0 » 7.x-5.x-dev
Status: Active » Fixed

Congrats, Nigel! You've got your first Drupal commit attribution. http://drupal.org/user/21923

Fixed. http://drupalcode.org/project/zen.git/commitdiff/a4fb10d

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.