Closed (fixed)
Project:
Nice Menus
Version:
7.x-2.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
30 Apr 2012 at 19:15 UTC
Updated:
13 Apr 2013 at 09:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
BrockBoland commentedBy default, new menu items do NOT have the "Show as expanded" option checked. If this were implemented right now, Nice Menus would (probably?) stop working pretty much across the board.
We could add an option to the Nice Menu block configuration to choose whether or not to use the "Show as expanded" option should be considered when building sub-menus. I'm not sure if this would be over-complicating the Nice Menu block configuration form, but it's also a real use-case that needs to be addressed.
In any case, I'm going to write a patch to add this option to the block configure form, and jenlampton and others can review to see how it looks.
Comment #2
BrockBoland commentedThis patch adds a new Respect "Show as expanded" option option on Nice Menu blocks, as seen here:
_%20block%20%7C%20local.nm_.com-1.png)
I'm not sold on the help text below it though, I think this needs review more than anything else:
Comment #3
BrockBoland commentedWhoops! As seen in the screenshot attached on this comment.
Comment #4
ykyuen commentedI applied this patch to 7.x-2.1 version but the nice menu still does not expand by default. i am using omega theme.
Comment #5
BrockBoland commented@ykyuen: The selected items won't be expanded by default, they simply will NOT include child elements if the "Show as expanded" option isn't checked.
Comment #6
ykyuen commentedic. thanks.
Comment #7
xiukun.zhou commentedThanks a lot to BrockBoland, jenlampton and everyone else for the great work on the patches, testing, reviews and reporting. This is a very good patch, but I did some simple modifications
It's more time this got committed and I went ahead and had this rolled at: 7.x-2.x: c247a99.
Marking this as fixed.
Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyne for the help and great work on this issue.
Cheers!